Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Direct3D backend #121

Merged
merged 10 commits into from
Mar 10, 2025
Merged

Expose Direct3D backend #121

merged 10 commits into from
Mar 10, 2025

Conversation

Kation
Copy link

@Kation Kation commented Apr 8, 2024 •
edited
Loading

Description of Change

Expose Direct3D backend

SkiaSharp Issue

Related to mono/SkiaSharp#2817

API Changes

Added:

  • gr_direct_context_t* gr_direct_context_make_direct3d(const gr_d3d_backendcontext_t d3dBackendContext);
  • gr_direct_context_t* gr_direct_context_make_direct3d_with_options(const gr_d3d_backendcontext_t d3dBackendContext, const gr_context_options_t* options);
  • gr_backendtexture_t* gr_backendtexture_new_direct3d(int width, int height, const gr_d3d_textureinfo_t* d3dInfo);
  • gr_backendrendertarget_t* gr_backendrendertarget_new_direct3d(int width, int height, const gr_d3d_textureinfo_t* d3dInfo);

Behavioral Changes

None.

Required SkiaSharp PR

None.

PR Checklist

  • Rebased on top of skiasharp at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@Kation
Copy link
Author

Kation commented Apr 8, 2024

@dotnet-policy-service agree

@Kation Kation mentioned this pull request Apr 8, 2024
Merged
5 tasks
mattleibow
mattleibow reviewed Apr 10, 2024
View reviewed changes
Copy link

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR - I see CI is green. I have a whole bunch of comments that is more just API shape and general interop.

@ShadowMarker789
Copy link

Is there any movement on getting this merged? A D3D Skia context would be great to have for us SkiaSharp users.

@mattleibow
Copy link

The things seem to work without having to wrap and unwrap the sp and cp, so we can merge now. Then if there are issues in the future with reference counting, we can always address it then.

@mattleibow mattleibow merged commit 1c3113a into mono:skiasharp Mar 10, 2025
1 check passed
@ShadowMarker789 ShadowMarker789 mentioned this pull request Mar 11, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kation @ShadowMarker789 @mattleibow